Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

KM498 ✅ Rotate GitHub deploy key #14

Merged
merged 8 commits into from
Feb 21, 2022
Merged

KM498 ✅ Rotate GitHub deploy key #14

merged 8 commits into from
Feb 21, 2022

Conversation

yngvark
Copy link
Contributor

@yngvark yngvark commented Feb 11, 2022

Description

oslokommune/okctl#894 introduces the ed25519 algorithm for deploy keys. We need to upgrade existing deploy keys, which uses an old algorithm, which will be deprecated by GitHub soon.

This upgrade deletes any previous existing deploy keys in GitHub for this cluster, and then creates one deploy key. It imports a version of Okctl that uses the new ed25519 algorithm.

Motivation and Context

https://trello.com/c/9GxBElfD/498-argocd-stops-working-2022-03-15-due-to-old-format-of-deploy-key

How to prove the effect of this PR?

Additional info

Upgrade for oslokommune/okctl#894

Documentation: https://okctl-2.ghost.io/ghost/#/editor/post/62066142c91338003b4883e2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@yngvark yngvark marked this pull request as ready for review February 11, 2022 09:41
@yngvark yngvark requested a review from a team February 11, 2022 09:41
@yngvark yngvark changed the title KM498 🐛 Rotate GitHub deploy key KM498 ✅ Rotate GitHub deploy key Feb 11, 2022
Copy link
Member

@deifyed deifyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Consider moving the key creation code over to this repo so its not dependent on the okctl release. That way you'll be able to release the upgrade before the okctl release ref best practice discussions

@yngvark
Copy link
Contributor Author

yngvark commented Feb 21, 2022

We need to update state, meaning we need to import okctl. When we already have okctl, we might as well use the key creation from there instead of copying it.

@yngvark yngvark merged commit 43aae4e into main Feb 21, 2022
@yngvark yngvark deleted the rotate_ssh_key branch February 21, 2022 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants