Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenLayers 7.2.2 -> 9.2.4 (and related updates) #2406

Merged
merged 27 commits into from
Aug 30, 2024

Conversation

ZakarFin
Copy link
Member

@ZakarFin ZakarFin commented Sep 5, 2023

Also updated:

  • babel 7.23.5 -> 7.25.2
  • cesium 1.91 -> cesium/engine 10.1.0
  • olcs 2.13.1 -> 2.20
  • jest 27.0.6 -> 29.7.0 (requires new dependency jest-environment-jsdom)

@ZakarFin
Copy link
Member Author

@ZakarFin
Copy link
Member Author

Still problems with the build.

With Cesium 1.109:

ERROR in ../oskari-frontend/node_modules/@cesium/engine/Source/Core/buildModuleUrl.js
Module parse failed: Unexpected token (41:27)
File was processed with these loaders:
 * ../oskari-frontend/node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|   if (typeof CESIUM_BASE_URL !== "undefined") {
|     baseUrlString = CESIUM_BASE_URL;
>   } else if (defined(import.meta) && defined(import.meta.url)) {
|     // ESM
|     baseUrlString = getAbsoluteUri(".", import.meta.url);
 @ ../oskari-frontend/node_modules/@cesium/engine/Source/Core/Iau2006XysData.js 1:0-49 203:11-25
 @ ../oskari-frontend/node_modules/@cesium/engine/Source/Core/Transforms.js
 @ ../oskari-frontend/node_modules/@cesium/engine/Source/Scene/Model/I3dmLoader.js
 @ ../oskari-frontend/node_modules/@cesium/engine/index.js
 @ ../oskari-frontend/node_modules/cesium/Source/Cesium.js
 @ ./node_modules/oskari-frontend/bundles/mapping/mapmodule/mapmodule.olcs.js

With Cesium 1.111:

ERROR in ../oskari-frontend/node_modules/@cesium/engine/Source/Core/buildModuleUrl.js 42:43
Module parse failed: Unexpected token (42:43)
File was processed with these loaders:
 * ../oskari-frontend/node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|   if (typeof CESIUM_BASE_URL !== "undefined") {
|     baseUrlString = CESIUM_BASE_URL;
>   } else if (defined((_import$meta = import.meta) === null || _import$meta === void 0 ? void 0 : _import$meta.url)) {
|     // ESM
|     baseUrlString = getAbsoluteUri(".", import.meta.url);
 @ ../oskari-frontend/node_modules/@cesium/engine/Source/Core/Iau2006XysData.js 1:0-49 203:11-25
 @ ../oskari-frontend/node_modules/@cesium/engine/Source/Core/Transforms.js
 @ ../oskari-frontend/node_modules/@cesium/engine/Source/Scene/Model/GeoJsonLoader.js
 @ ../oskari-frontend/node_modules/@cesium/engine/index.js
 @ ../oskari-frontend/node_modules/cesium/Source/Cesium.js
 @ ./node_modules/oskari-frontend/bundles/mapping/mapmodule/mapmodule.olcs.js

Tried configuring this for babel but it didn't affect the outcome:

    "babel-plugin-transform-import-meta": "^2.2.1",

@ZakarFin
Copy link
Member Author

Tried updating babel-core & co in #2513 (merged it here) but doesn't seem to help.

@ZakarFin ZakarFin changed the title Update OpenLayers 7.2.2 -> 7.5.2 (and jQuery) Update OpenLayers 7.2.2 -> 7.5.2 Nov 16, 2023
@ZakarFin ZakarFin marked this pull request as ready for review August 30, 2024 06:31
@ZakarFin ZakarFin changed the title Update OpenLayers 7.2.2 -> 7.5.2 Update OpenLayers 7.2.2 -> 9.2.4 (and related updates) Aug 30, 2024
@ZakarFin ZakarFin added this to the 2.14.0 milestone Aug 30, 2024
@ZakarFin ZakarFin merged commit 56d858d into oskariorg:develop Aug 30, 2024
1 check passed
@ZakarFin ZakarFin deleted the update-ol branch August 30, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant