allow usage of additional hostnames in self signed certificate #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controlled by env var ADDITIONAL_HOSTNAMES should be comma separated list as per cfssl documentation
|
merged in v1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controlled by env var ADDITIONAL_HOSTNAMES
should be comma separated list as per cfssl documentation
My use case is relatively simple explained. I'm using your openldap image in kubernetes and I'd like to be able have replication between masters encrypted as well as encrypted traffic through the service load balancing.
For this to work I need to be able to setup additional Hostnames for the generated certificates. I'm already using this change by simply injecting the modified script through a configmap without any problems.