Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapping of device and volume to be used for getting uuid #1411

Merged
merged 5 commits into from
Nov 15, 2020
Merged

Add mapping of device and volume to be used for getting uuid #1411

merged 5 commits into from
Nov 15, 2020

Conversation

tausiflife
Copy link
Collaborator

No description provided.

@tausiflife tausiflife linked an issue Nov 15, 2020 that may be closed by this pull request
Linux: OSFileStore.getUUID() returns empty string for logical volumes #1404
Closed
dbwiddis
dbwiddis approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, one comment inline. Don't forget the changelog.

oshi-core/src/main/java/oshi/software/os/linux/LinuxFileSystem.java Outdated Show resolved Hide resolved
@tausiflife
Copy link
Collaborator Author

Thanks! Looks good, one comment inline. Don't forget the changelog.

ok will add it :)

@coveralls
Copy link

coveralls commented Nov 15, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 89.474% when pulling 1d744ac on tausiflife:linux-uuid into f071290 on oshi:master.

@tausiflife
Copy link
Collaborator Author

@dbwiddis Will you be doing the merge or should I?

@dbwiddis
Copy link
Member

Go ahead and squash-and-merge if tests pass after the listFiles() change.

@tausiflife tausiflife merged commit 3c19c75 into oshi:master Nov 15, 2020
@dbwiddis
Copy link
Member

Thanks for handling this!

@tausiflife
Copy link
Collaborator Author

Anytime :-) I will try my best to help you and this project whenever i can.

@dbwiddis dbwiddis mentioned this pull request Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux: OSFileStore.getUUID() returns empty string for logical volumes
3 participants
@tausiflife @coveralls @dbwiddis