HTCONDOR-2253 Fix CERequirements when default_CERequirements not set #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bug in the CERequirements post transform in base CE configuration. The wrong value is set if default_CERequirements isn't set in the route. A fix will be released in V23. Here, we apply the same fix for Hosted CEs user older HTCondor-CE versions.
|
LGTM on the helm side (can't speak to the condor side). Unless you want someone to look over that specifically, I say I merge it. Also do we have a jira issue for this? I think it would be good to have something for us to remember to remove this once all the CEs are on the latest image. |
|
The HTCondor config change was approved by Cole in HTCONDOR-2276 as part of the next HTCondor-CE V23 release. I'm not aware of any jira issue for helm changes that can/should happen once all all CEs are using the latest version. I'll see about making one. |
|
Can someone give an official thumbs-up? |
brianhlin
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug in the CERequirements post transform in base CE configuration. The wrong value is set if default_CERequirements isn't set in the route. A fix will be released in V23. Here, we apply the same fix for Hosted CEs user older HTCondor-CE versions.