Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook Oembed Page-Photo issue #405

Closed
reflexxion opened this issue Nov 18, 2020 · 0 comments · Fixed by #406
Closed

Facebook Oembed Page-Photo issue #405

reflexxion opened this issue Nov 18, 2020 · 0 comments · Fixed by #406

Comments

@reflexxion
Copy link
Contributor

Hi,

I just found an issue in the facebook oEmbed docs (new api from 24th Oct).
In the URL Formats section they do not list "Photos in pages" but indeed this url scheme work for the "oembed_post" endpoint.

The URL format for that case should be https://www.facebook.com/{page-name}/photos/{id}
E.g. https://www.facebook.com/amrum/photos/a.10161026612345162/10161026614895162/

Using the integrated "embed post" this type of post is embeddable.

https://developers.facebook.com/docs/plugins/embedded-posts/?prefill_href=https%3A%2F%2Fwww.facebook.com%2Famrum%2Fphotos%2Fa.10161026612345162%2F10161026614895162%2F&__tn__=p*F#code-generator

I'll create a pull request for v4. v3.x is not necessary because the conditions are way different.

Section in v4:
https://github.com/oscarotero/Embed/blob/master/src/Adapters/Facebook/OEmbed.php#L57-L67
(always use page as fallback, so it does not work)

Section in v3:
https://github.com/oscarotero/Embed/blob/v3.x/src/Providers/OEmbed/Facebook.php#L55
(always use post as fallback, so it works)

reflexxion pushed a commit to RedaktionsNetzwerk-Deutschland/Embed that referenced this issue Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant