-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isomorphism(PermGroup, ::WeylGroup)
for missing irreducible types
#4478
base: master
Are you sure you want to change the base?
isomorphism(PermGroup, ::WeylGroup)
for missing irreducible types
#4478
Conversation
This is a continuation of #4264, I guess. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4478 +/- ##
==========================================
+ Coverage 84.36% 84.40% +0.03%
==========================================
Files 663 672 +9
Lines 87805 88708 +903
==========================================
+ Hits 74077 74873 +796
- Misses 13728 13835 +107
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have a few comments, mostly documentation-related. Once they are resolved, I would be happy to merge this PR. If you prefer to wait until reducible types are working, this would be fine for me as well.
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
Thanks for your comments! I resolved everything. I plan to look into the reducible types soonish, but I see no harm in merging already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adaptions! Could you please have a look into the two failing CI jobs? Both should have some instructions in the failure log. Once that's done, this is good to go from my POV.
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
Sure, will do that next week. |
I applied JuliaFormatter and bibtool and fixed the bib entry (changed "article" to "Article"). Now it's all fine (except for the nightly test). |
Adds support for all missing irreducible types (B, C, D, E, F, G) in
isomorphism(PermGroup, ::WeylGroup)
and also for non-canonical orderings. Reducible types are still missing.@lgoettgens I don't know whether this should be merged already, but I think the code is mature enough for someone else to have a look.