Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isomorphism(PermGroup, ::WeylGroup) for missing irreducible types #4478

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

TWiedemann
Copy link
Contributor

Adds support for all missing irreducible types (B, C, D, E, F, G) in isomorphism(PermGroup, ::WeylGroup) and also for non-canonical orderings. Reducible types are still missing.

@lgoettgens I don't know whether this should be merged already, but I think the code is mature enough for someone else to have a look.

@TWiedemann
Copy link
Contributor Author

This is a continuation of #4264, I guess.

@lgoettgens lgoettgens added topic: LieTheory experimental Only changes experimental parts of the code labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (91f076a) to head (c5def11).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4478      +/-   ##
==========================================
+ Coverage   84.36%   84.40%   +0.03%     
==========================================
  Files         663      672       +9     
  Lines       87805    88708     +903     
==========================================
+ Hits        74077    74873     +796     
- Misses      13728    13835     +107     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/WeylGroup.jl 94.73% <100.00%> (+5.60%) ⬆️
experimental/LieAlgebras/test/WeylGroup-test.jl 100.00% <ø> (ø)

... and 76 files with indirect coverage changes

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few comments, mostly documentation-related. Once they are resolved, I would be happy to merge this PR. If you prefer to wait until reducible types are working, this would be fine for me as well.

experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/WeylGroup.jl Outdated Show resolved Hide resolved
@TWiedemann
Copy link
Contributor Author

Thanks for your comments! I resolved everything. I plan to look into the reducible types soonish, but I see no harm in merging already.

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adaptions! Could you please have a look into the two failing CI jobs? Both should have some instructions in the failure log. Once that's done, this is good to go from my POV.

docs/oscar_references.bib Outdated Show resolved Hide resolved
docs/oscar_references.bib Outdated Show resolved Hide resolved
TWiedemann and others added 2 commits January 17, 2025 16:49
@TWiedemann
Copy link
Contributor Author

Thanks for the adaptions! Could you please have a look into the two failing CI jobs? Both should have some instructions in the failure log. Once that's done, this is good to go from my POV.

Sure, will do that next week.

@TWiedemann
Copy link
Contributor Author

TWiedemann commented Jan 20, 2025

I applied JuliaFormatter and bibtool and fixed the bib entry (changed "article" to "Article"). Now it's all fine (except for the nightly test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: LieTheory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants