Fix casing in show(::PBWAlgebra) and friends
#4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
commented
Nov 14, 2024
| from pBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z | ||
| to (PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z)/two_sided_ideal(x^2, y^2, z^2) | ||
| from PBW-algebra over rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z | ||
| to (PBW-algebra over rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z)/two_sided_ideal(x^2, y^2, z^2) |
There was a problem hiding this comment.
these two lines show all fixes to the casing in one place
lgoettgens
changed the title
show(::PBWAlgebra) and friends
lgoettgens
force-pushed
the
lg/show-PBWAlgebra
branch
from
4bd2f90
to
d6a8012
Compare
fingolfin
reviewed
Nov 15, 2024
| @@ -35,13 +35,13 @@ If `I` is an ideal of a PBW-algebra `A`, then | |||
|
|
|||
| ```jldoctest | |||
| julia> D, (x, y, dx, dy) = weyl_algebra(QQ, ["x", "y"]) | |||
| (Weyl-algebra over Rational field in variables (x, y), PBWAlgElem{QQFieldElem, Singular.n_Q}[x, y, dx, dy]) | |||
| (Weyl-algebra over rational field in variables (x, y), PBWAlgElem{QQFieldElem, Singular.n_Q}[x, y, dx, dy]) | |||
There was a problem hiding this comment.
Orthogonal to this PR (and not a change request for it): it really also should be Weyl algebra and PBW algebra (without the -)
fingolfin
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and similar for
PBWAlgQuoandPBWAlgOppositeMap.This does not implement the modes of printing yet, but is intended to keep changes in output minimal. But it required to completely rewrite the
showmethods in question. And while at it, I also made use of@show_special.