Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_left and is_right for SubgroupTransversal #4298

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

fingolfin
Copy link
Member

Also use is_left/is_right for those and cosets

Also use is_left/is_right for those and cosets
src/Groups/cosets.jl Outdated Show resolved Hide resolved
src/Groups/cosets.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.49%. Comparing base (194d82b) to head (16cc394).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/Groups/cosets.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4298      +/-   ##
==========================================
- Coverage   84.49%   84.49%   -0.01%     
==========================================
  Files         641      641              
  Lines       85528    85525       -3     
==========================================
- Hits        72269    72264       -5     
- Misses      13259    13261       +2     
Files with missing lines Coverage Δ
src/Groups/cosets.jl 96.02% <90.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fingolfin fingolfin merged commit d0984f8 into master Nov 13, 2024
30 checks passed
@fingolfin fingolfin deleted the mh/groups-left-right branch November 13, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants