Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add characteristic for multivariate quotient rings over fields #4241

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

joschmitt
Copy link
Member

Addresses #4239 for fields. The is_zero call needs a Gröbner basis which uses a cached basis, if one was already computed.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (5c30f3a) to head (ddccc33).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4241   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         631      631           
  Lines       85060    85064    +4     
=======================================
+ Hits        71954    71958    +4     
  Misses      13106    13106           
Files with missing lines Coverage Δ
src/Rings/MPolyQuo.jl 92.08% <100.00%> (+0.05%) ⬆️

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fingolfin fingolfin merged commit eaa8972 into master Oct 24, 2024
30 checks passed
@fingolfin fingolfin deleted the js/charquo branch October 24, 2024 20:23
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants