Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GAP.jl 0.11.3 resp. GAP 4.13.1 #3688

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Update to GAP.jl 0.11.3 resp. GAP 4.13.1 #3688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0001b03
Update to GAP.jl 0.11.0 resp. GAP 4.13.0
fingolfin Apr 5, 2024
c52c17d
Disable a failing test for now
fingolfin May 4, 2024
058dba7
Adjust tests
fingolfin May 5, 2024
7e0d37f
Revert "Disable a failing test for now"
fingolfin Jun 13, 2024
3615688
Adjust book example
fingolfin Jun 14, 2024
1ebab9f
fix `GAP.julia_to_gap(T::SubgroupTransversal)`
ThomasBreuer Sep 11, 2024
3420c47
Update Project.toml
lgoettgens Sep 11, 2024
0d25050
Update Project.toml
lgoettgens Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cohomCalg_jll = "5558cf25-a90e-53b0-b813-cadaa3ae7ade"
AbstractAlgebra = "0.42.3"
AlgebraicSolving = "0.5.1"
Distributed = "1.6"
GAP = "0.10.2"
GAP = "0.11.3"
Hecke = "0.33.0"
JSON = "^0.20, ^0.21"
JSON3 = "1.13.2"
Expand Down
2 changes: 1 addition & 1 deletion src/Groups/GAPGroups.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,8 +1024,8 @@ julia> G = symmetric_group(5);
julia> low_index_subgroup_classes(G, 5)
3-element Vector{GAPGroupConjClass{PermGroup, PermGroup}}:
Conjugacy class of Sym(5) in G
Conjugacy class of Alt(5) in G
Conjugacy class of permutation group in G
Conjugacy class of Alt(5) in G
```
"""
function low_index_subgroup_classes(G::GAPGroup, n::Int)
Expand Down
2 changes: 1 addition & 1 deletion src/Groups/cosets.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ struct SubgroupTransversal{T<: GAPGroup, S<: GAPGroup, E<: GAPGroupElem} <: Abst
X::GapObj # underlying *right* transversal in GAP
end

GAP.julia_to_gap(T::SubgroupTransversal) = T.X
GAP.julia_to_gap(T::SubgroupTransversal, d::IdDict{Any,Any} = IdDict(); recursive::Bool = false) = T.X

function Base.show(io::IO, ::MIME"text/plain", x::SubgroupTransversal)
side = x.side === :left ? "Left" : "Right"
Expand Down
8 changes: 4 additions & 4 deletions src/Groups/directproducts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ julia> elements(G)
(4,5)
(2,3)
(2,3)(4,5)
(1,2)
(1,2)(4,5)
(1,2,3)
(1,2,3)(4,5)
(1,3,2)
(1,3,2)(4,5)
(1,3)
(1,3)(4,5)
(1,2,3)
(1,2,3)(4,5)
(1,2)
(1,2)(4,5)
```
"""
function direct_product(L::AbstractVector{<:GAPGroup}; morphisms::Bool=false)
Expand Down
4 changes: 2 additions & 2 deletions src/Groups/homomorphisms.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,10 +544,10 @@ Pc group of order 6
julia> iso = isomorphism(PermGroup, G)
Group homomorphism
from pc group of order 6
to permutation group of degree 6 and order 6
to permutation group of degree 3 and order 6

julia> permutation_group(G)
Permutation group of degree 6 and order 6
Permutation group of degree 3 and order 6

julia> codomain(iso) === ans
true
Expand Down
4 changes: 2 additions & 2 deletions test/book/cornerstones/groups/actions.jlcon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ Group homomorphism
julia> isomorphism(PermGroup, U)
Group homomorphism
from pc group of order 8
to permutation group of degree 8 and order 8
to permutation group of degree 4 and order 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example was originally intended to demonstrate that isomorphism is in general not good enough to get such a small degree for the image. Now this part of the book chapter becomes less suggestive.
(Since the final proofs of the Oscar book are still not available, do we have a chance to replace this example in the book by a better one? Of course the next release of GAP may then destroy the effect again ...)


julia> permutation_group(U)
Permutation group of degree 8 and order 8
Permutation group of degree 4 and order 8

julia> for g in all_transitive_groups(degree => 3:9, !is_primitive)
h = image(optimal_perm_rep(g))[1]
Expand Down
Loading