-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair quotient rings #2788
Repair quotient rings #2788
Conversation
Was it decided at one of the Kaiserslautern meetings, that we'd rather have a hash functions which errors than a slow default one? |
Yes. This was @fieker 's proposal. |
This is similar to oscar-system/GAP.jl#891. |
Codecov Report
@@ Coverage Diff @@
## master #2788 +/- ##
==========================================
- Coverage 73.63% 73.58% -0.05%
==========================================
Files 455 455
Lines 64411 64443 +32
==========================================
- Hits 47427 47422 -5
- Misses 16984 17021 +37 |
Looks like the code coverage report is nothing that can be taken serious these days. All coverage changes occur in places that I did not touch; not even indirectly! I suppose this is due to the various failing tests? Either way: I would like to point to #2789 if anyone feels like doing a proper review. |
f.f == g.f && return true | ||
hash(f) == hash(g) && return true # calls simplify already | ||
return f.f == g.f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong to me. Please double check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. What was I thinking...? Corrected in #2789 .
CC: @wdecker , @fingolfin @fieker