Polyhedron: add and use is_lattice_polytope check #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and enforce lattice property for several properties that depend on this
benlorenz
force-pushed
the
bl/latticepoly
branch
from
bb50e89
to
cd987d3
Compare
fingolfin
reviewed
Mar 18, 2023
|
|
||
| julia> h_star_polynomial(c) | ||
| x^3 + 23*x^2 + 23*x + 1 | ||
| ``` |
There was a problem hiding this comment.
Off-topic, but: That's the second or third time I've recently seen this kind of issue (missing or misplaced triple backquote). I totally can see this happening to me as well, and I wonder if there is some tool or check we can activate to find these systematically?
lkastner
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforce lattice property for several properties that depend on this
this fixes some parts of #2066.
cc: @lkastner