New mark function for Julia object #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasguts
force-pushed
the
sg/mark_julia_objs
branch
from
ef16389
to
04f3714
Compare
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 75.21% 78.52% +3.31%
==========================================
Files 5 5
Lines 456 517 +61
==========================================
+ Hits 343 406 +63
+ Misses 113 111 -2
|
sebasguts
force-pushed
the
sg/mark_julia_objs
branch
from
04f3714
to
0318e06
Compare
fingolfin
previously approved these changes
Apr 23, 2019
to ensure julia function object is marked correctly if julia function gets marked.
sebasguts
force-pushed
the
sg/mark_julia_objs
branch
from
0318e06
to
801e22c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the marking functions for Julia objects by using the marking functions introduced in gap-system/gap#3412