Remove JuliaModule #1041
Merged
Remove JuliaModule #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/remove-JuliaModule
branch
3 times, most recently
from
3795b64
to
f000bca
Compare
We didn't use it and JuliaModule("bla") can simply be replaced by Julia.bla
fingolfin
force-pushed
the
mh/remove-JuliaModule
branch
from
f000bca
to
bf98787
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 74.39% 74.33% -0.07%
==========================================
Files 55 55
Lines 4527 4515 -12
==========================================
- Hits 3368 3356 -12
Misses 1159 1159
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't use it and JuliaModule("bla") can simply be replaced by Julia.bla