Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Trestle release #1737

Merged
merged 1 commit into from
Oct 22, 2024
Merged

chore: Trestle release #1737

merged 1 commit into from
Oct 22, 2024

Conversation

jpower432
Copy link
Member

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Trestle release - Take 2

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@jpower432
fix(build): installs required build dependencies during semantic rele…
4dbdf7d 
…ase build (#1736)

Semantic release is running in a container that does
not have access to the dependencies installed in `make
develop` step

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review October 22, 2024 20:16
AleJo2995
AleJo2995 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 7d3ee4c into main Oct 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleJo2995 AleJo2995 AleJo2995 approved these changes

@butler54 butler54 Awaiting requested review from butler54

@vikas-agarwal76 vikas-agarwal76 Awaiting requested review from vikas-agarwal76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @AleJo2995