Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): restructuring of API documentation #1711

Merged
merged 22 commits into from
Oct 31, 2024
Merged

Conversation

butler54
Copy link
Collaborator

@butler54 butler54 commented Sep 26, 2024

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

  • Users no longer need to update mkdocs to add a page.
  • All pages have been moved to be in the same relative path for SEO
  • Social previews will now be generated
  • Descriptions for SEO
  • Flavicons

More work needs to be done.

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@butler54 butler54 changed the title chore(docs): Restructuring of API documentation chore(docs): restructuring of API documentation Sep 26, 2024
@butler54 butler54 requested review from degenaro and jpower432 October 8, 2024 05:03
@butler54
Copy link
Collaborator Author

butler54 commented Oct 8, 2024

@jpower432 / @degenaro a first pass review here would be helpful. All the descriptions (Where BANANAS has been put to have a key to replace) need to be updated.

Highlights:

  1. Tree structure automatically creates the website
  2. No need to update mkdocs.yaml to add a file. In 90% of locations this will happen automatically.

@butler54 butler54 marked this pull request as ready for review October 9, 2024 03:43
@jpower432 jpower432 added this to the v3.6.0 milestone Oct 30, 2024
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Deployed locally and reviewed the changes. I don't see any issues with the changes made.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Signed-off-by: Chris Butler <[email protected]>
@butler54 butler54 enabled auto-merge (squash) October 31, 2024 01:12
Signed-off-by: Chris Butler <[email protected]>
@butler54 butler54 merged commit 17e9ae3 into develop Oct 31, 2024
14 checks passed
@butler54 butler54 deleted the restructure-api-docs branch October 31, 2024 02:54
@degenaro
Copy link
Collaborator

@butler54 I see you've already delivered. I pulled develop branch and doc serves works for me. Hopefully Reference -> API will be improved with future code restructuring.

d10n pushed a commit to d10n/compliance-trestle that referenced this pull request Nov 12, 2024
Back end update to clean up documentation website

Signed-off-by: Chris Butler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants