Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates communication details in README.md #1537

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

jpower432
Copy link
Member

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site) (README.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Updates Community meeting details in README.md

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

This is a seperate meeting/communication channel
from the Compliance WG adding new meeting details and slack channel

Signed-off-by: Jennifer Power <[email protected]>
@jpower432
Copy link
Member Author

This is in draft pending the addition of the notes link only. Other changes can be reviewed in the meantime.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review April 22, 2024 15:03
Signed-off-by: Alejandro Jose Leiva Palomo <[email protected]>
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have updated the convert time tool as the previous link didn't work

Copy link
Member

@mrgadgil mrgadgil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@degenaro
Copy link
Collaborator

re: lint fail

This is annoying. I had the same problem in #1533. I fixed by changing id to id_ in 2 places. This will be further annoying when #1533 is delivered to develop if there's a conflict. Ugh.

Signed-off-by: Alejandro Jose Leiva Palomo <[email protected]>
@AleJo2995
Copy link
Collaborator

@degenaro Do you know why is this happening in the end? I'm applying the fix temporarily because we need to merge this details before tomorrow's call, but I haven't found a reason either. And what I see is weirder is that locally I'm not being able to reproduce it

@jpower432
Copy link
Member Author

Thanks for adding the fix @AleJo2995. CI is passing now, is this good to merge?

@AleJo2995 AleJo2995 merged commit eb459a2 into develop Apr 22, 2024
15 checks passed
@AleJo2995 AleJo2995 deleted the docs/update-meeting-details branch April 22, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants