-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source for osbuild-deploy-container command #11
Conversation
Since we have no intentions of pushing this to RHEL for now, what if we don't vendor? We can always start if we need to. |
Sure, we can drop the vendoring. I imagine that might make builds a bit slower (and annoying when rebuilding locally) since after cloning the repo and starting the container build, it will have to fetch all the dependencies inside the container. |
Noticed a couple of other issues here:
|
That's true. 🤔 Not sure if this trade-off is worth it. |
Easy to fix if it gets annoying. |
Single-use binary for deploying a container image using rpm-ostree.
Add a pipelines function based on the Fedora CoreOS deployment pipelines and partition tables. Hardcode the container source for now. A NullWorkload is defined that implements the images Workload interface.
The manifest builds and boots successfully when run manually through osbuild.
The dnf depsolver, dnf-json, is now packages as osbuild-depsolve-dnf. Let's install it from the package instead of relying on the images repository.
Update the entrypoint with double minus for long flags.
- The imgref is now a positional argument. - The config option requires two dashes.
This is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
FTR: Tested working on a Fedora 39 host, built (and booted) quay.io/centos-boot/fedora-tier-1:eln |
Partially replaces #5.
This PR adds the source code for the
osbuild-deploy-container
command, which up until now was only available in a branch on my fork of the images repository.It depends on some open PRs in the osbuild/images repository for now.
Depends on: