helpers.linux.kernfs: add kernfs_children() and follow_symlinks support #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add kernfs_children() to iterate all kernfs_node in children rb_tree. Signed-off-by: Kuan-Ying Lee <[email protected]>
Extend kernfs_walk() to support symlink. Signed-off-by: Kuan-Ying Lee <[email protected]>
brenns10
reviewed
Oct 29, 2024
Comment on lines
+72
to
+74
| :param follow_symlinks: If follow_symlinks is ``False``, and the | ||
| last component of a path is a symlink, the function will | ||
| return ``struct kernfs_node *`` of the symbolic link. |
There was a problem hiding this comment.
Why only the last component?
I guess I don't know well enough whether there are cases where symlinks would be in the middle of a real kernfs path. So maybe it won't make a difference. It just seems reasonable to support it within the path too.
There was a problem hiding this comment.
That probably came from my description in #443. My intention was that internal symlinks are always followed, and the last one is controlled by the parameter, just like O_NOFOLLOW and the os module. I haven't read the code to see if there was a misunderstanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kernfs_children() to iterate over the children of a directory in kernfs.
Add support of follow_symlinks.