Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ChatGPT support #94

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

feat: add ChatGPT support #94

wants to merge 17 commits into from

Conversation

baruchiro
Copy link
Collaborator

@baruchiro baruchiro commented Jun 4, 2023 •
edited
Loading

  • move finder code to share with all content
  • rename indicator.js -> create-element.js
  • move element creation to create-element
  • inject contentElementSelector
  • include the self element in findRanges
  • add the content.chatgpt to build

Part of #86

Need help with the style:
image

@baruchiro baruchiro linked an issue Jun 4, 2023 that may be closed by this pull request
Implement on ChatGPT, Bard, New bing #86
Open
Merge remote-tracking branch 'origin/master' into 86-implement-on-cha…
85b389b 
…tgpt-bard-new-bing-all-these-needs-prompt-to-reproduce-a-package-suggestion
@baruchiro baruchiro removed a link to an issue Jun 4, 2023
Implement on ChatGPT, Bard, New bing #86
Open
@baruchiro baruchiro requested review from jossef and GuyNachshon and removed request for jossef June 4, 2023 12:14
@GuyNachshon
Copy link
Collaborator

it seems like we have two options to solve this:

  1. diverge the CSS when we are on chatgpt's URL to manipulate the color
  2. add a more comprehended solution traversing up to the first background colour and determining the colour based on it.

@baruchiro @jossef WDYT?

@baruchiro baruchiro added the UI label Jun 5, 2023
@baruchiro
Merge branch 'master' into 86-implement-on-chatgpt-bard-new-bing-all-…
4c02cf9 
…these-needs-prompt-to-reproduce-a-package-suggestion
@baruchiro
Copy link
Collaborator Author

On Hold: Waiting for @jossef to finish the Figma styles and support dark mode.

@baruchiro baruchiro self-assigned this Jun 11, 2023
Merge remote-tracking branch 'upstream/master' into 86-implement-on-c…
0e5e38f 
…hatgpt-bard-new-bing-all-these-needs-prompt-to-reproduce-a-package-suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuyNachshon GuyNachshon Awaiting requested review from GuyNachshon

At least 1 approving review is required to merge this pull request.

Assignees

@baruchiro baruchiro

Labels
on hold UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baruchiro @GuyNachshon