Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action menu - create settings page #27

Open
jossef opened this issue Mar 15, 2023 · 7 comments
Open

action menu - create settings page #27

jossef opened this issue Mar 15, 2023 · 7 comments
Assignees
Labels
Milestone

Comments

@jossef
Copy link
Member

jossef commented Mar 15, 2023

No description provided.

@jossef jossef self-assigned this Mar 15, 2023
@jossef jossef added this to the 1.0.0 milestone Mar 15, 2023
@baruchiro
Copy link
Collaborator

@jossef please throw settings here

@jossef
Copy link
Member Author

jossef commented Mar 30, 2023

Image

@baruchiro
Copy link
Collaborator

Save the state between browser restarts

@baruchiro
Copy link
Collaborator

I'm thinking about these settings on a Popup. As a user, I think I expect it to affect the page immediately, means that on a StackOverflow page, when I will disable one of the advisories, I will expect the "issues counters" to withdraw, without refresh.

On the other hand, if the setting is in the Oprions page, it will be expected the settings will take effect only after a page refresh.

@jossef WDYT?

@jossef
Copy link
Member Author

jossef commented Apr 2, 2023

If we'll place a copy of those enable/disable settings in our global reactive store, the vue component can filter the disabled ones and ignore em' with immediate reaction.

This means we will need to remove the global issues counter and let the vue component calculate it (should be a simple sum)

@baruchiro
Copy link
Collaborator

Right. So we choose to activate the settings immediately?

@jossef
Copy link
Member Author

jossef commented Apr 2, 2023

Right. So we choose to activate the settings immediately?

👍

jossef added a commit that referenced this issue Apr 20, 2023
First work of #27.

In this PR I created the infrastructure for controlling the state of the
extension from its popup.

See the review comments for specific implementation details.

![tinywow_Recording 2023-04-03
200726_18612307](https://user-images.githubusercontent.com/17686879/229579780-e3326381-9db4-440c-bbed-9a5036070a1b.gif)

---------

Co-authored-by: Jossef Harush Kadouri <[email protected]>
@baruchiro baruchiro added the UI label Apr 30, 2023
@baruchiro baruchiro assigned baruchiro and unassigned baruchiro Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants