Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report missing bug references of softfails, don't just write a log line #181

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

Martchus
Copy link
Contributor

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of adding new fixture builds you could move one of those jobs with missing details to one of the existing builds, add the according job status to one of the overview pages and cover there

@Martchus
Copy link
Contributor Author

Martchus commented Oct 13, 2021

That's what I was trying in the first place but it was really complicated to do as I'm not really sure what the review script needs. I suppose I'll strip down the fixtures as much as possible first to find that out, e.g. many of the page elements are likely not required and one job is likely sufficient as well. If I know the minimum I'll check whether I can integrate it somewhere else but if it is really small it might make sense to keep it isolated (because it is actually an advantage not to mix everything up).

@Martchus Martchus force-pushed the report-missing-bugrefs branch from 8fa8893 to 752d6c3 Compare October 13, 2021 11:44
@Martchus Martchus marked this pull request as ready for review October 13, 2021 11:45
@Martchus
Copy link
Contributor Author

Martchus commented Oct 13, 2021

The fixtures are now really reduced to the minimum. Mixing them into different files would likely make it just more confusing. (I could strip down the HTML a little bit more but I think a bit context makes it better to understand.)

@okurz okurz merged commit fb80610 into os-autoinst:master Oct 13, 2021
@Martchus Martchus deleted the report-missing-bugrefs branch October 13, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants