feat: migration box now supports autocommit DDL changes #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To better support CockroachDB, a new migration type ("autocommit") has been added. Autocommit migrations will not be executed in a transaction, which resolves issues in when running large DDL changes in crdb transactions.
To use this feature, just add `.autocommit` to the filename:
```
1234_name.autocommit.up.sql < does not run in transaction
1234_name.up.sql < runs in transaction
```
Works with all combinations:
```
1234_name.postgres.autocommit.up.sql
```
aeneasr
force-pushed
the
migrator-cockroach-ddl
branch
from
e3d8c16 to
0dd59c2
Compare
zepatrik
reviewed
Oct 31, 2024
popx/match.go
Outdated
| "github.com/gobuffalo/pop/v6" | ||
| ) | ||
|
|
||
| var mrx = regexp.MustCompile(`^(\d+)_([^.]+)(\.[a-z0-9]+)?\.(up|down)(|\.autocommit)\.(sql|fizz)$`) |
There was a problem hiding this comment.
As we're not using fizz, we can just completely remove it?
Suggested change
| var mrx = regexp.MustCompile(`^(\d+)_([^.]+)(\.[a-z0-9]+)?\.(up|down)(|\.autocommit)\.(sql|fizz)$`) | |
| var mrx = regexp.MustCompile(`^(\d+)_([^.]+)(\.[a-z0-9]+)?\.(up|down)(|\.autocommit)\.sql$`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better support CockroachDB, a new migration type ("autocommit") has been added. Autocommit migrations will not be executed in a transaction, which resolves issues in when running large DDL changes in crdb transactions.
To use this feature, just prefix the file extension with
.autocommit:Works with all combinations:
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments