fix: occasional jsonnet timeouts #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnr
force-pushed
the
alnr/jsonnet-timeouts2
branch
from
56aace8 to
d316cc9
Compare
alnr
force-pushed
the
alnr/jsonnet-timeouts2
branch
from
3032a24 to
9f1c25b
Compare
zepatrik
reviewed
Aug 6, 2024
zepatrik
approved these changes
Aug 6, 2024
aeneasr
reviewed
Aug 6, 2024
| @@ -79,12 +70,6 @@ func WithProcessIsolatedVM(ctx context.Context) Option { | |||
| } | |||
| } | |||
|
|
|||
| func WithExecTimeout(timeout time.Duration) Option { | |||
There was a problem hiding this comment.
If you remove this it needs an update in depending services as well!
There was a problem hiding this comment.
I grepped our code bases and found no uses. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #798 and #799
The fixed 1 second timeout now only applies to the Jsonnet evaluation step,
but not the the spawning of the process which can occasionally take longer.
Additionally, we now warm the pool asynchronously on construction.