Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved SSRF protection #747

Merged
merged 1 commit into from
Nov 20, 2023
Merged

feat: improved SSRF protection #747

merged 1 commit into from
Nov 20, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Nov 13, 2023

No description provided.

@alnr alnr requested a review from zepatrik November 13, 2023 17:50
@alnr alnr self-assigned this Nov 13, 2023
@alnr alnr force-pushed the ssrf branch 8 times, most recently from 364f106 to c718a58 Compare November 17, 2023 13:05
@alnr alnr marked this pull request as ready for review November 20, 2023 09:40
@alnr alnr requested a review from hperl November 20, 2023 09:40
hperl
hperl approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice and clean!

httpx/private_ip_validator.go Show resolved Hide resolved
@alnr alnr merged commit 022d9bd into master Nov 20, 2023
9 checks passed
@alnr alnr deleted the ssrf branch November 20, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepatrik zepatrik zepatrik approved these changes

@hperl hperl hperl approved these changes

Assignees

@alnr alnr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alnr @hperl @zepatrik