Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: health/alive handler never errors #685

Merged
merged 2 commits into from
Apr 12, 2023
Merged

fix: health/alive handler never errors #685

merged 2 commits into from
Apr 12, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Apr 12, 2023

This is problematic during code generation in downstream projects ever since ory/herodot#106. Since the handler never returns an error (a failing liveness check means you don't get a response at all), the simplest and most correct thing to do is to just not declare an error type at all.

@alnr alnr self-assigned this Apr 12, 2023
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handler itself might not error, but you could e.g. get a 504 or similar. I think you can provide default instead of a status code as well.

@alnr
Copy link
Contributor Author

alnr commented Apr 12, 2023

The handler itself might not error, but you could e.g. get a 504 or similar. I think you can provide default instead of a status code as well.

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants