Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dart support #50

Merged
merged 6 commits into from
Jan 25, 2021
Merged

add dart support #50

merged 6 commits into from
Jan 25, 2021

Conversation

jsiedentop
Copy link
Contributor

Based on the work of sachaarbonel I added the generation of the dart client.

I did not finish the publishing part in release.sh, because the ownership of the package should be at ory. The steps are documented at: https://dart.dev/tools/pub/publishing

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2021

CLA assistant check
All committers have signed the CLA.

@jsiedentop jsiedentop mentioned this pull request Jan 21, 2021
@aeneasr
Copy link
Member

aeneasr commented Jan 25, 2021

Thank you for your effort! I will now look into dart publishing :)

@aeneasr
Copy link
Member

aeneasr commented Jan 25, 2021

Looks like it is not currently supported to publish dart packages as a CI task: dart-lang/pub#2227

@aeneasr aeneasr added the feat New feature or request. label Jan 25, 2021
@aeneasr aeneasr self-assigned this Jan 25, 2021
@aeneasr
Copy link
Member

aeneasr commented Jan 25, 2021

Ok, so I have published the raw packages now:

Apparently it is possible to run this in a CI. Will try to do that now.

@jsiedentop
Copy link
Contributor Author

jsiedentop commented Jan 25, 2021

Awesome! That was quick 👍 I'm happy to use the official packages instead of the local build ones. Good luck with the CI part.

@aeneasr aeneasr merged commit 6579f47 into ory:master Jan 25, 2021
@aeneasr
Copy link
Member

aeneasr commented Jan 25, 2021

Awesome! I think this should work now as part of the CI. I will do a test run now!

@jsiedentop
Copy link
Contributor Author

I created a new issue, because the published client is invalid and differs from the client I generated locally.

@jsiedentop jsiedentop deleted the add-dart-support branch January 26, 2021 11:29
@aeneasr aeneasr mentioned this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants