fix: adds tracing to cookie_session and bearer_token authenticators #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing works for oauth2_introspect type authenticators but fails for
bearer_token
orcookie_session
type of authenticators as the headers aren't updated with a proper parent span created by oathkeeper.Changing this, the parent span from the incoming request is updated with an oathkeeper span creating a proper trace in monitoring tools.
Caution: Enabling the tracing injects tracing headers into requests which now need explicit allowlisting since 0.39.x versions.
Related issue(s)
Tracing is broken when using
cookie_session
andbearer_token
authenticators as headers can be merely propagated by usingforward_http_headers
but they aren't properly updated. This created wrong layouts in tracing tools.Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
Happy to discuss this if needed 😉