feat: allow fallback when using JWT #958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to use the
jwt
authenticator alongside thebearer_token
authenticator. Our application receives requests with different token type, both in theAuthorization
header. Thebearer_token
tokens are not JWTs.Currently this is not possible, as the JWT authenticator declares itself responsible as long as any token is provided at the correct location.
With the proposed change, the JWT authenticator will only declare itself responsible if the token at least looks like a JWT (
<header>.<payload>.<signature>
). That way, a subsequent authenticator can attempt authentication with the same token.Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.