Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make glob patterns match only one path segment. #664

Merged
merged 1 commit into from
Mar 16, 2021
Merged

fix: Make glob patterns match only one path segment. #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rule/engine_glob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,5 @@ func compileGlob(pattern string, delimiterStart, delimiterEnd rune) (glob.Glob,
buffer.WriteString(glob.QuoteMeta(raw))

// Compile full regexp.
return glob.Compile(buffer.String())
return glob.Compile(buffer.String(), '.', '/')
}
9 changes: 9 additions & 0 deletions rule/engine_glob_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,15 @@ func TestIsMatch(t *testing.T) {
want: true,
wantErr: false,
},
{
name: "asterisk matches only one path segment",
args: args{
pattern: `http://example.com/<*>`,
matchAgainst: "http://example.com/foo/bar",
},
want: false,
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down