feat: Add support for X-Forwarded-Proto header #638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#153 @aeneasr @Entrio
Proposed changes
Add basic support for the header
X-Forwarded-Proto
which is normally set by an edge proxy like Ambassador, Istio, Traefik, Envoy, etc.The proposed changes affect only the decision API as it is expected to be contacted by another proxy which will take care of SSL termination in most cases. It is important to notice that even if traffic reaching oathkeeper is plain HTTP, it does not mean that the traffic is not encrypted in transit. A good example is service mesh where Envoy or similar technologies (e.g. Linkerd) will secure traffic in transit through sidecars and mTLS.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
The changes proposed here have been tested in our development environment and they work like a charm for both proper rules matching and redirection URLs.