fix: remove token_type validation from authenticator_oauth2 introspec… #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authenticator_oauth2 introspection flow only works if the
token_type
is anaccess_token
. It works great if your authentication server always return this type but it crashes if returns other types.Related issue
#553
Proposed changes
My proposal is to remove this validation and allow other
token_type
's. I have checked RFC but I didn't find what types should be allowed so my suggestion is to allow any token_type.Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
There is no docs to update.