Extend ID_TOKEN mutator with custom claims #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2019
aeneasr
approved these changes
Aug 14, 2019
aeneasr
reviewed
Aug 14, 2019
pipeline/mutate/mutator_id_token.go
Outdated
| @@ -41,23 +44,29 @@ type MutatorIDTokenRegistry interface { | |||
| } | |||
|
|
|||
| type CredentialsIDTokenConfig struct { | |||
| Audience []string `json:"aud"` | |||
| Audience []string `json:"aud"` | |||
There was a problem hiding this comment.
I guess the question is if we want to keep this or not. As now we can use the claims portion instead.
There was a problem hiding this comment.
True. Do you want me to delete it?
There was a problem hiding this comment.
Yeah, I think that makes sense - but we have to document that in the upgrade guide .)
aeneasr
reviewed
Aug 19, 2019
jakkab
force-pushed
the
feature/id-token-custom-claims
branch
from
19af64c to
4826011
Compare
|
If you need help with the e2e tests lmk |
aeneasr
reviewed
Aug 20, 2019
pipeline/mutate/mutator_id_token.go
Outdated
| templateID := rl.GetID() | ||
| tmpl = a.t.Lookup(templateID) | ||
| if tmpl == nil { | ||
| tmpl, err = a.t.New(templateID).Parse(string(config)) |
There was a problem hiding this comment.
This should be Prase(string(CredentialsIDTokenConfig.Claims)
There was a problem hiding this comment.
Wait, are you sure? I thought we execute the template first to avoid those parsing errors!
jakkab
force-pushed
the
feature/id-token-custom-claims
branch
from
f3f3ac2 to
92aa903
Compare
|
Thank you so much for your work - I've made some changes to this PR and merged it with #246 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#228
Proposed changes
Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.