Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved tracing for authorizers #1079

Merged
merged 1 commit into from
Mar 15, 2023
Merged

feat: improved tracing for authorizers #1079

merged 1 commit into from
Mar 15, 2023

Conversation

alnr
Copy link
Collaborator

@alnr alnr commented Mar 14, 2023

No description provided.

@alnr alnr requested review from hperl and zepatrik March 14, 2023 15:25
@alnr alnr requested a review from aeneasr as a code owner March 14, 2023 15:25
@alnr alnr self-assigned this Mar 14, 2023
@alnr alnr force-pushed the remote-json-tracing branch from 8cb85ae to 75160b4 Compare March 15, 2023 10:41
@alnr alnr force-pushed the remote-json-tracing branch from 75160b4 to 43c3177 Compare March 15, 2023 10:42
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1079 (125fcf1) into master (bba14ba) will decrease coverage by 0.52%.
The diff coverage is 100.00%.

❗ Current head 125fcf1 differs from pull request most recent head 43c3177. Consider uploading reports for the commit 43c3177 to get more accurate results

@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
- Coverage   78.45%   77.94%   -0.52%     
==========================================
  Files          80       80              
  Lines        3806     3935     +129     
==========================================
+ Hits         2986     3067      +81     
- Misses        548      589      +41     
- Partials      272      279       +7     
Impacted Files Coverage Δ
driver/registry_memory.go 90.45% <100.00%> (ø)
pipeline/authz/keto_engine_acp_ory.go 68.26% <100.00%> (+1.26%) ⬆️
pipeline/authz/remote.go 73.56% <100.00%> (+1.61%) ⬆️
pipeline/authz/remote_json.go 88.88% <100.00%> (+0.82%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, the Keto authorizer is for a very old version of Keto and does not support the latest releases.

@aeneasr aeneasr merged commit b3aa0c3 into master Mar 15, 2023
@aeneasr aeneasr deleted the remote-json-tracing branch March 15, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants