Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL validator rejects valid upstream URLs #930

Closed
3 of 6 tasks
rwos opened this issue Feb 22, 2022 · 0 comments · Fixed by #953
Closed
3 of 6 tasks

URL validator rejects valid upstream URLs #930

rwos opened this issue Feb 22, 2022 · 0 comments · Fixed by #953
Assignees
Labels
bug Something is not working.

Comments

@rwos
Copy link

rwos commented Feb 22, 2022

Preflight checklist

Describe the bug

Upstream URLs of the form http://tasks.foo-bar_baz (and possibly others) are rejected as invalid, while they are perfectly valid. This is one of the forms Docker Swarm's internal DNS hostnames take (service baz in the stack foo-bar).

Reproducing the bug

  1. Set upstream.url to http://tasks.foo-bar_baz

Relevant log output

time=2022-02-22T10:37:26Z level=error msg=A Rule uses a malformed configuration and all URLs matching this rule will not work. You should resolve this issue now. audience=application error=map[debug: message:An internal server error occurred, please contact the system administrator reason:Value "http://tasks.foo-bar_baz" of "upstream.url" is not a valid url. status:Internal Server Error status_code:500] rule_id=ory:foo:protected-bar service_name=ORY Oathkeeper service_version=v0.38.19-beta.1-17-g74c2581

Relevant configuration

No response

Version

v0.38.19-beta.1-17-g74c2581

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Docker

Additional Context

No response

@rwos rwos added the bug Something is not working. label Feb 22, 2022
@aeneasr aeneasr self-assigned this Apr 11, 2022
aeneasr added a commit that referenced this issue Apr 11, 2022
aeneasr added a commit that referenced this issue Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants