Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jwt): replace jwt module #818

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

ecktom
Copy link
Contributor

@ecktom ecktom commented Sep 7, 2021

A while ago we switched this project to use github.com/form3tech-oss/jwt-go as github.com/dgrijalva/jwt-go wasn't maintained anymore (#635).
In the meantime the open source community came up with a new repository to combine the efforts of maintaining a jwt module.
Based on https://github.com/golang-jwt/jwt/blob/main/MIGRATION_GUIDE.md the v4 should be fully backwards compatible so that I don't expect any issues to pop up. This PR will also fix #691 as support was recently added in golang-jwt/jwt#36

@ecktom ecktom requested a review from aeneasr as a code owner September 7, 2021 18:22
@aeneasr
Copy link
Member

aeneasr commented Sep 8, 2021

Thank you! Looks like there are some compile issues, could you please take a look?

@ecktom ecktom force-pushed the feat/replace_jwt_module branch from be72f3c to 238c117 Compare September 8, 2021 07:43
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #818 (238c117) into master (0dcd1f5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #818   +/-   ##
=======================================
  Coverage   62.37%   62.37%           
=======================================
  Files         102      102           
  Lines        4787     4787           
=======================================
  Hits         2986     2986           
  Misses       1528     1528           
  Partials      273      273           
Impacted Files Coverage Δ
credentials/signer_default.go 63.26% <ø> (ø)
credentials/verifier_default.go 79.76% <ø> (ø)
pipeline/authn/authenticator_jwt.go 82.45% <ø> (ø)
pipeline/mutate/mutator_id_token.go 81.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dcd1f5...238c117. Read the comment docs.

@ecktom
Copy link
Contributor Author

ecktom commented Sep 8, 2021

Thank you! Looks like there are some compile issues, could you please take a look?

Turns out that auth0/go-jwt-middleware which is used in the e2e tests is not yet compatible with the new module. See also:
auth0/go-jwt-middleware#95
auth0/go-jwt-middleware#96

@aeneasr aeneasr merged commit 301b673 into ory:master Sep 10, 2021
@aeneasr
Copy link
Member

aeneasr commented Sep 10, 2021

Awesome, thank you! 🎉 Your contribution makes Ory better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EdDSA is an unsupported algorithm
2 participants