Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible | breaking change on callback function signature in jwtmiddleware options #96

Closed
eregnier opened this issue Jul 7, 2021 · 2 comments

Comments

@eregnier
Copy link

eregnier commented Jul 7, 2021

Hey, I have this error with the latest version of this library. It looks like the callback function signature does not match current ValidationKeyGetter option value.

I don't know how to solve this as I did not change my code and the code is broken. So it looks like a regression / breaking change where I do not have a clue how to solve as the readme example remains unchanged and looks not compatible with the current library version.

I don't know which version I was using before, however now I have updated this library and it is up to date on my workstation.

Is there something to do on my side ? Am I missing something ?

I work on linux (ubuntu) with go go version go1.16.3 linux/amd64

Thank you for any help :)

image

@grounded042
Copy link
Contributor

Hey @eregnier, sorry you are facing this. If you look at #69 you can see what lead to this breaking change. The decision was made to have this breaking change in order to fix a security vulnerability.

A contributing factor to this issue is that up until this point this package has not been versioned.

I'm guessing you are pulling in github.com/dgrijalva/jwt-go? If you change that to github.com/form3tech-oss/jwt-go you should be good to go.

@eregnier
Copy link
Author

eregnier commented Jul 7, 2021

it works. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants