Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make glob patterns match only one path segment. #664

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

cameron-martin
Copy link
Contributor

Related issue

Fixes #630.

Proposed changes

This makes / also a separator for glob patterns as well as the presumably default value of .. This allows using <*> for matching only one path segment.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2021

CLA assistant check
All committers have signed the CLA.

@cameron-martin cameron-martin changed the title Make glob patterns match only one path segment. fix: Make glob patterns match only one path segment. Mar 15, 2021
This makes `/` also a separator as well as the presumably default value of `.`.
This allows using <*> for matching only one path segment.

Fixes ory#630.
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit c711aac into ory:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glob "*" match separator "/"
3 participants