Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README building-from-source part with the gomodule way #149

Closed
pink-lucifer opened this issue Dec 26, 2018 · 2 comments
Closed

Update README building-from-source part with the gomodule way #149

pink-lucifer opened this issue Dec 26, 2018 · 2 comments

Comments

@pink-lucifer
Copy link
Contributor

As latest release have already been migrated to go module, the dep doesn't work any more, it would be better to update the instructions same as keto or hydra does, or add up additional note to clarify.

README - building-from-source

hydra - README - buiding from source
@aeneasr
Copy link
Member

aeneasr commented Dec 26, 2018

Nice catch! Would you mind creating a PR?

@pink-lucifer
Copy link
Contributor Author

@aeneasr
I apologize that i didn't follow up on this response timely, is this taken care of?
It would be my pleasure to work on this PR.

@pink-lucifer pink-lucifer mentioned this issue Jan 22, 2019
Merged
6 tasks
pink-lucifer added a commit to pink-lucifer/oathkeeper that referenced this issue Jan 22, 2019
@pink-lucifer
issue ory#149 - Update README building-from-source part with the gomo…
60872f6 
…dule way

Signed-off-by: pink-lucifer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeneasr @pink-lucifer