Skip to content

Commit

Permalink
server: Properly declare negroni middleware (#200)
Browse files Browse the repository at this point in the history
Previously, negroni.With was mistakenly used to add middleware onto the stack.
The proper method however is negroni.Use.

This patch fixes the use of negroni.With and resolves issues around
logging and the decisions endpoint.

Closes #199
  • Loading branch information
aeneasr authored May 28, 2019
1 parent 244810a commit 9d3dc54
Show file tree
Hide file tree
Showing 15 changed files with 702 additions and 315 deletions.
3 changes: 2 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
vendor/
node_modules
node_modules
dist/
9 changes: 4 additions & 5 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: Bug report
about: Create a report to help us improve

---

**Describe the bug**
Expand All @@ -18,15 +17,15 @@ Steps to reproduce the behavior:
3. Request fails with response: `{"some": "error"}`
-->

*Server logs*
_Server logs_

<!--
```
log=error ....
```
-->

*Server configuration*
_Server configuration_

<!--
PLEASE OMIT SENSITIVE VALUES
Expand All @@ -44,8 +43,8 @@ A clear and concise description of what you expected to happen.

**Environment**

* Version: v1.2.3, git sha hash
* Environment: Debian, Docker, ...
- Version: v1.2.3, git sha hash
- Environment: Debian, Docker, ...

**Additional context**

Expand Down
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
---
name: Feature request
about: Suggest an idea for this project

---

**Is your feature request related to a problem? Please describe.**

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]

**Describe the solution you'd like**

A clear and concise description of what you want to happen.

**Describe alternatives you've considered**

A clear and concise description of any alternative solutions or features you've considered.
A clear and concise description of any alternative solutions or features you've
considered.

**Additional context**

Add any other context or screenshots about the feature request here.

4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/security.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: Disclose (potential) security vulnerability
about: Disclose security vulnerabilities to [email protected]
---

Please refrain from publishing (potential) security vulnerabilities publicly
on the forums, the chat, or GitHub.
Please refrain from publishing (potential) security vulnerabilities publicly on
the forums, the chat, or GitHub.

We describe how to disclose (potential) security vulnerabilities in our
[Security Policy](SECURITY.md)
10 changes: 6 additions & 4 deletions .github/ISSUE_TEMPLATE/support.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
---
name: Support request
about: Please use our forums (community.ory.sh) or the chat (ory.sh/chat) to ask for support

about:
Please use our forums (community.ory.sh) or the chat (ory.sh/chat) to ask for
support
---

Please use issues only to file potential bugs or request features. For everything else please go to
the [ORY Community](https://community.ory.sh/) or join the [ORY Chat](https://www.ory.sh/chat).
Please use issues only to file potential bugs or request features. For
everything else please go to the [ORY Community](https://community.ory.sh/) or
join the [ORY Chat](https://www.ory.sh/chat).
10 changes: 7 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,15 @@ them, don't hesitate to ask. We're here to help! This is simply a reminder of wh

- [ ] I have read the [contributing guidelines](CONTRIBUTING.md)
- [ ] I have read the [security policy](SECURITY.md)
- [ ] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
vulnerability, I confirm that I got green light (please contact [[email protected]](mailto:[email protected])) from the maintainers to push the changes.
- [ ] I confirm that this pull request does not address a security
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[[email protected]](mailto:[email protected])) from the maintainers to push
the changes.
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation within the code base (if appropriate)
- [ ] I have documented my changes in the [developer guide](https://github.com/ory/docs) (if appropriate)
- [ ] I have documented my changes in the
[developer guide](https://github.com/ory/docs) (if appropriate)

## Further comments

Expand Down
Loading

0 comments on commit 9d3dc54

Please sign in to comment.