Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for compiler error (Unable to initialize compiler: lstat /go: no such file or directory) #77

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Conversation

sum2000
Copy link
Contributor

@sum2000 sum2000 commented Jan 23, 2019

Related issue

#73 @aeneasr

Proposed changes

Added placeholder .go files inside rego and its subfolders to force download rego folder when we run go mod vendor

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

@aeneasr
Copy link
Member

aeneasr commented Jan 24, 2019

Thank you!

@aeneasr aeneasr merged commit 59cc053 into ory:master Jan 24, 2019
@sum2000
Copy link
Contributor Author

sum2000 commented Jan 24, 2019

@aeneasr the issue is not resolved completely, Dockerfile needs to be updated because your release image also needs the rego folder to run. People using docker images will still face this issue. For my local build, I did something like this for release container.

COPY --from=builder /go/pkg/mod/github.com/ory /go/pkg/mod/github.com/ory

This line copies everything in local ory folder to release image ory folder. I needed this for my environment. You might just need keto/engine/ladon/rego in this case.

@aeneasr
Copy link
Member

aeneasr commented Jan 24, 2019

Hm that's strange, we're using packer to build the binary which should include the source code - otherwise the docker image wouldn't start at all (it does tho last time I checked). See this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants