Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the version of './contrib/cat-videos-example/docker-compose.yml' #595

Merged
merged 1 commit into from
May 14, 2021
Merged

fix: update the version of './contrib/cat-videos-example/docker-compose.yml' #595

merged 1 commit into from
May 14, 2021

Conversation

lmt-swallow
Copy link
Contributor

@lmt-swallow lmt-swallow commented May 13, 2021

Related issue

I got the following message when I tried to run "cat videos example" in the way this guide explains:

$ git clone [email protected]:ory/keto.git && cd keto
(blah blah)
$ docker-compose -f contrib/cat-videos-example/docker-compose.yml up --build
ERROR: The Compose file './contrib/cat-videos-example/docker-compose.yml' is invalid because:
services.keto.volumes contains an invalid type, it should be a string
services.keto-init.volumes contains an invalid type, it should be a string

This issue was originally the one reported in the pull request #549, and the pull request fixed the issue of ./docker-compose-postgres.yml indeed. However, ./contrib/cat-videos-example/docker-compose.yml still seems broken.

Proposed changes

Update version: '3' to version: '3.2' as suggested in #549 .

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@CLAassistant
Copy link

CLAassistant commented May 13, 2021

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr requested a review from zepatrik May 14, 2021 13:06
@aeneasr aeneasr merged commit 7fa4dca into ory:master May 14, 2021
@aeneasr
Copy link
Member

aeneasr commented May 14, 2021

Awesome, thank you!

@lmt-swallow lmt-swallow deleted the patch-1 branch May 15, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants