Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TLS option to serve API #46

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Enable TLS option to serve API #46

merged 2 commits into from
Aug 31, 2018

Conversation

fredbi
Copy link
Contributor

@fredbi fredbi commented Aug 31, 2018

  • refactor help messages

Signed-off-by: Frederic BIDON [email protected]

* refactor help messages

Signed-off-by: Frederic BIDON <[email protected]>
@fredbi
Copy link
Contributor Author

fredbi commented Aug 31, 2018

Some refactoring has been carried out. Next I believe, some parts now identical might be factorized in the common package.

@fredbi
Copy link
Contributor Author

fredbi commented Aug 31, 2018

Note: the interface for metrics-middleware has changed while writing this PR. Padded missing args (sampling, endpoint) with some default values. I am really not sure about those. Please advise.

@aeneasr
Copy link
Member

aeneasr commented Aug 31, 2018

As long as metrics-middleware isn't bumped in version this is fine!

@aeneasr aeneasr merged commit 2f62063 into ory:master Aug 31, 2018
@aeneasr
Copy link
Member

aeneasr commented Aug 31, 2018

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants