Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add initial e2e test #380

Merged
merged 5 commits into from
Dec 21, 2020
Merged

test: add initial e2e test #380

merged 5 commits into from
Dec 21, 2020

Conversation

zepatrik
Copy link
Member

This adds a e2e test running on each of sqlite, mysql, postgres, and cockroach.
More cases will be added soon.

@zepatrik zepatrik changed the title Use namespace manager in cli test: add initial e2e test Dec 18, 2020
@zepatrik zepatrik requested a review from aeneasr December 18, 2020 16:31
go func() {
defer wg.Done()

<-ctx.Done()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

Comment on lines 134 to 139
req, err := http.NewRequest(http.MethodPut, "http://127.0.0.1:4466/relationtuple", bytes.NewBuffer(lndTupleEnc))
require.NoError(t, err)
resp, err := http.DefaultClient.Do(req)
require.NoError(t, err)
require.NoError(t, resp.Body.Close())
assert.Equal(t, http.StatusCreated, resp.StatusCode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably implement a small body, res := testhelper.MakeRequest() to make this easier to read when more things are added

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@zepatrik zepatrik merged commit dc5d3c9 into zanzibar Dec 21, 2020
@zepatrik zepatrik deleted the use-namespace-manager-in-cli branch December 21, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants