-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unified APIs with REST, gRPC and Connect RPC #1659
base: master
Are you sure you want to change the base?
Conversation
The API specs all remain the same? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there are a few breaking changes in the OpenAPI spec, but not too many
spec/api.json
Outdated
"operationId": "patchRelationships", | ||
"requestBody": { | ||
"content": { | ||
"application/json": { | ||
"schema": { | ||
"items": { | ||
"$ref": "#/components/schemas/relationshipPatch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
spec/api.json
Outdated
@@ -517,33 +504,12 @@ | |||
} | |||
}, | |||
"description": "errorGeneric" | |||
}, | |||
"404": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
This PR unifies the API service implementations between REST and gRPC, and adds with the support for Connect RPC a third protocol, all via Vanguard.
The advantages are as follows:
Requests flow through the system as follows:
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments