Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move to common Ory migration helpers #1640

Closed
wants to merge 1 commit into from
Closed

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 2, 2024

This patch brings Ory Keto SQL migrations in line with CLI patterns from Kraots and Hydra.

BREAKING CHANGE: Please update your migration scripts:

- keto migrate up
+ keto migrate sql up

- keto migrate down 2
+ keto migrate sql down --steps 2

- keto migrate status
+ keto migrate sql status

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This patch brings Ory Keto SQL migrations in line with CLI patterns from Kraots and Hydra.

BREAKING CHANGE: Please update your migration scripts:

```patch
- keto migrate up
+ keto migrate sql up

- keto migrate down 2
+ keto migrate sql down --steps 2

- keto migrate status
+ keto migrate sql status
```
@aeneasr
Copy link
Member Author

aeneasr commented Dec 2, 2024

The migrate cmd in keto is a bit more complex, and since we already have down migrations there's no point really in investing more time

@aeneasr aeneasr closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant