Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts protos should use grpc-js #1513

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: ts protos should use grpc-js #1513

merged 1 commit into from
Feb 27, 2024

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Feb 27, 2024

This will eliminate our dependency on node 16.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from zepatrik as a code owner February 27, 2024 14:53
@hperl hperl requested a review from jonas-jonas February 27, 2024 14:53
@hperl hperl self-assigned this Feb 27, 2024
@hperl hperl enabled auto-merge February 27, 2024 15:50
@hperl hperl added this pull request to the merge queue Feb 27, 2024
Merged via the queue into master with commit 6a75032 Feb 27, 2024
24 checks passed
@hperl hperl deleted the hperl/fix-ts-protos branch February 27, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants