Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace JS SDK generator with ts-proto generator #1508

Closed
wants to merge 2 commits into from

Conversation

jonas-jonas
Copy link
Member

This replaces the existing generators with https://github.com/stephenh/ts-proto, which can generate more user friendly code. It also allows generating client for the nice-grpc framework.

BREAKING CHANGE: The structure of the JS SDK had to be changed to match the new generated code.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Feb 2, 2024
Comment on lines 2 to +3
"name": "@ory/keto-grpc-client",
"version": "0.6.0-alpha.1",
"version": "0.12.0-alpha.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to

@ory/client-grpc

@aeneasr
Copy link
Member

aeneasr commented Jul 4, 2024

I'm closing these PRs as we never got it to work. This problem hasn't come up in the past few months so I think it's on the bench for now :D

@aeneasr aeneasr closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants