Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache OPL when loading from HTTP(S) #1429

Merged
merged 1 commit into from
Sep 19, 2023
Merged

feat: cache OPL when loading from HTTP(S) #1429

merged 1 commit into from
Sep 19, 2023

Conversation

alnr
Copy link
Collaborator

@alnr alnr commented Sep 15, 2023 •
edited
Loading

@alnr alnr self-assigned this Sep 15, 2023
@alnr alnr requested review from zepatrik and hperl as code owners September 15, 2023 11:42
aeneasr
aeneasr requested changes Sep 18, 2023
View reviewed changes
internal/driver/config/opl_cache_test.go Outdated
_, err = cw.GetNamespaceByName(ctx, "Document")
require.NoError(t, err)

time.Sleep(1 * time.Second) // warm cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use cache.Wait() instead, otherwise this will be flaky

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, brilliant!

@aeneasr aeneasr merged commit b89ce02 into master Sep 19, 2023
21 checks passed
@aeneasr aeneasr deleted the fetcher-caching branch September 19, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr requested changes

@zepatrik zepatrik zepatrik approved these changes

@hperl hperl Awaiting requested review from hperl hperl is a code owner

Assignees

@alnr alnr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alnr @aeneasr @zepatrik